Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra info for zelle, sepa, sepa instant #1527

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woodser
Copy link
Contributor

@woodser woodser commented Jan 7, 2025

No description provided.

@woodser woodser changed the title add extra info to zelle payment method add extra info for zelle, sepa, sepa instant Jan 9, 2025
@woodser woodser marked this pull request as draft January 9, 2025 14:34
@woodser woodser marked this pull request as ready for review January 9, 2025 18:16
@woodser woodser marked this pull request as draft January 9, 2025 18:48
@boldsuck
Copy link
Contributor

Nice, have patched client and new SEPA accounts with info for 0-deposit-offer ;-)

@woodser
Copy link
Contributor Author

woodser commented Jan 11, 2025

I'm considering adding extra information to offers directly, instead of through payment accounts.

That would allow extra info for any case, including contact details for no deposit offers with any fiat or crypto payment account.

Then extra info for payment accounts is not really needed.

@boldsuck
Copy link
Contributor

I'm considering adding extra information to offers directly, instead of through payment accounts.

I think this is less work and users do not have to create new payment accounts.
Bonus: Users can change extra information for each offer.

@shortwavesurfer2009
Copy link
Contributor

I like it. That makes more sense to me anyway.

@phytohydra
Copy link
Contributor

I'm not exactly opposed, but I thought that, cumbersome as it is, it works that way for a reason: If users see that a payment account is a certain age, they know that all the information is unchanged for that duration.

There was a case on Localmonero where somebody took over a high-reputation account, changed the payment information to their own, and scammed everybody who traded with it from that point on. The users ultimately got paid out of the escrowed XMR by the arbitrators, but it still allowed the hijackers to drain the account, which they couldn't do directly without its password. It fit the profile of them hijacking the account by stealing the logged-in computer.

@boldsuck
Copy link
Contributor

If users see that a payment account is a certain age, they know that all the information is unchanged for that duration.

Payment relevant information cannot be changed afterwards.
Only extra info such as: email, simplex link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants